feat(semanticTokens)!: token highlight groups #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4667 +/- ##
==========================================
- Coverage 98.57% 98.55% -0.03%
==========================================
Files 273 273
Lines 26077 26049 -28
Branches 5392 5385 -7
==========================================
- Hits 25705 25672 -33
- Misses 219 223 +4
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. |
|
Isn't this creating multiple (about 2-4 times more) highlight spans on the same tokens in n/vim side? And it does not fix the issue about priority in #4659. |
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
from
2176e52 to
2286f64
Compare
|
It's now working for me. We should also update |
And commit message? According to #4659 discussion, current commit/PR description is outdated. |
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
from
2286f64 to
0cb6074
Compare
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
4 times, most recently
from
72531de to
f6b512b
Compare
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
from
8aab7c8 to
84f7940
Compare
|
Needs rebase latest fixes and improve this. |
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
2 times, most recently
from
113f59e to
7a655fb
Compare
CocSemType + type CocSemMod + modifier CocSemTypeMod + type + modifier The highlight group didn't need to be defined first related #4659
CocSemType + type CocSemTypeMod + type + modifier
modifiers are added to one token type, we can't list them directly
fannheyward
force-pushed
the
feat/semantic-tokens-hi
branch
from
7a655fb to
429e89b
Compare
|
@oxalica merged to master, feedbacks are welcome. |
fannheyward
added a commit
that referenced
this pull request
Mar 26, 2024
9190bfe feat(list): add --buffer to list buffer diags (#4958) fb030d4 fix(defaultAction) fallback to default action on emtpy expression (#4954) 846994b fix(inlayHint): more compact padding highlight group (#4950) b01ae44 feat(semanticTokens)!: token highlight groups (#4667) 8c85d6f fix(markdown): incorrect list indentation alignment in markdown parser (#4884) 0d66554 fix(inlayHint): hl_mode = 'replace' for neovim (#4949) 1a8244e chore(package): update dependencies (#4948) 4f68722 feat(client): upgrade to marked 7 (#4947) 574c12c feat(package): @types/node@18 (#4946) d299c66 feat(menu): C-j/k to navigate menu (#4945) 34d3d9d chore(deps): bump follow-redirects from 1.15.4 to 1.15.6 (#4944) aead8f4 chore(CI): use Node 20 (#4940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
CocSem + typetoCocSem + Type + typeCocSem + modifier + typetoCocSem + TypeMod + type + modifierCocSem + modifierThe highlight group didn't need to be defined first.
semanticTokens.checkCurrentto the new highlight groups, onlyCocSemTypeXXXX, modifiers are added to one token type, we can't list them directly.related #4659